Add character sets: Arabic, Greek, Hebrew, Japanese, Thai, Korean #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! Do you happen to know whether any of these encodings also have an implementation at
A curious reference. The normative part of the standard would be in PS3.5 section 6.1, though I agree that the latest revisions do not expose the available character sets as nicely as in that table. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for the following character sets:
This is related to issue: #40, and is a superset of the currently open PR #444.
The full set of DICOM supported character sets is listed in: Table D.6.2-1. Supported Specific Character Set Defined Terms. This change covers the character sets in this list which are also supported by rust-encoding.
It appears that
rust-encodingdoes not include support for ISO-IR 148 (Latin 5) or ISO-IR 159 (Japanese supplementary characters), so these have not been included.